ArjunPakhan commented on PR #3771: URL: https://github.com/apache/iceberg-python/pull/3771#issuecomment-5231316892
Hi @tasty0tomato! 👋 Thanks for the thorough review and helpful pointers! I've updated the PR branch with the following changes: 1. Pushed the source changes in `pyiceberg/table/inspect.py` containing `_readable_bound` for 4-byte promoted bounds (`int -> long` and `float -> double`). 2. Applied `_readable_bound` to partition summaries in `manifests()` (lines 420-435) to handle promoted partition source columns cleanly. 3. Added an end-to-end `SqlCatalog` integration test in `tests/table/test_inspect.py` that verifies `inspect.files()`, `inspect.entries()`, and `inspect.manifests()` on a promoted table. All 6 inspect tests are passing locally! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
