Fokko commented on code in PR #3666:
URL: https://github.com/apache/iceberg-python/pull/3666#discussion_r3770094797
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1785,7 +1785,7 @@ def _can_contain_nans(self, field_id: int) -> bool:
return (nan_count := self.nan_counts.get(field_id)) is not None and
nan_count > 0
-class ResidualVisitor(BoundBooleanExpressionVisitor[BooleanExpression], ABC):
Review Comment:
Thanks for flagging. I don't think the rename is worth breaking possible
imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
