openinx commented on a change in pull request #1793:
URL: https://github.com/apache/iceberg/pull/1793#discussion_r553176851
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -91,7 +89,7 @@ public Builder env(StreamExecutionEnvironment newEnv) {
}
public Builder filters(List<Expression> filters) {
Review comment:
We've discussed this before in.
https://github.com/apache/iceberg/pull/1346#issuecomment-699056581 and
https://github.com/apache/iceberg/pull/1509#issuecomment-699778221. The
conclusion is : exposing only one simple `FlinkSource` API to end users ,
rather than expose two builders. That make sense to me, flink data stream
developers will find it's easier to construct the streaming source, though we
iceberg developers need to write those duplicated setters .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
