openinx commented on a change in pull request #1793:
URL: https://github.com/apache/iceberg/pull/1793#discussion_r553733979
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -101,57 +99,62 @@ public Builder project(TableSchema schema) {
}
public Builder limit(long newLimit) {
- this.limit = newLimit;
+ ctxtBuilder.limit(newLimit);
return this;
}
public Builder properties(Map<String, String> properties) {
- this.context = context.fromProperties(properties);
+ ctxtBuilder.fromProperties(properties);
return this;
}
public Builder caseSensitive(boolean caseSensitive) {
- this.context = context.setCaseSensitive(caseSensitive);
+ ctxtBuilder.caseSensitive(caseSensitive);
return this;
}
public Builder snapshotId(Long snapshotId) {
- this.context = context.useSnapshotId(snapshotId);
+ ctxtBuilder.useSnapshotId(snapshotId);
return this;
}
public Builder startSnapshotId(Long startSnapshotId) {
- this.context = context.startSnapshotId(startSnapshotId);
+ ctxtBuilder.startSnapshotId(startSnapshotId);
return this;
}
public Builder endSnapshotId(Long endSnapshotId) {
- this.context = context.endSnapshotId(endSnapshotId);
+ ctxtBuilder.endSnapshotId(endSnapshotId);
return this;
}
public Builder asOfTimestamp(Long asOfTimestamp) {
- this.context = context.asOfTimestamp(asOfTimestamp);
+ ctxtBuilder.asOfTimestamp(asOfTimestamp);
return this;
}
public Builder splitSize(Long splitSize) {
- this.context = context.splitSize(splitSize);
+ ctxtBuilder.splitSize(splitSize);
return this;
}
public Builder splitLookback(Integer splitLookback) {
- this.context = context.splitLookback(splitLookback);
+ ctxtBuilder.splitLookback(splitLookback);
return this;
}
public Builder splitOpenFileCost(Long splitOpenFileCost) {
- this.context = context.splitOpenFileCost(splitOpenFileCost);
+ ctxtBuilder.splitOpenFileCost(splitOpenFileCost);
+ return this;
+ }
+
+ public Builder streaming(boolean streaming) {
+ ctxtBuilder.streaming(streaming);
return this;
}
public Builder nameMapping(String nameMapping) {
- this.context = context.nameMapping(nameMapping);
Review comment:
Thanks for sharing the feeling from an English native speaker, I didn't
notice the slight difference in it before but I think it's worth to respect
this feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
