rdblue commented on code in PR #17433:
URL: https://github.com/apache/iceberg/pull/17433#discussion_r3779855592
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -85,7 +85,7 @@ class TrackedFileStruct extends SupportsIndexProjection
implements TrackedFile,
super(BASE_TYPE, projection);
// partition type may be null if the field was not projected, or unknown
for unpartitioned
// manifests
- Type partType = projection.fieldType("partition");
+ Type partType = projection.fieldType(TrackedFile.PARTITION_NAME);
Review Comment:
It's good to fix these cases, but I strongly prefer not doing it mixed in
with other changes in a PR. This file is only touched because of this change.
Unless this is fixing a bug, it should be a separate PR. You can include the
similar change to `StatsUtil`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
