singhpk234 commented on code in PR #16131:
URL: https://github.com/apache/iceberg/pull/16131#discussion_r3781692001
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -557,13 +558,22 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
}
List<Credential> credentials = response.credentials();
+ ReadRestrictions readRestrictions = response.readRestrictions();
RESTClient tableClient = client.withAuthSession(tableSession);
Supplier<BaseTable> tableSupplier =
createTableSupplier(
- finalIdentifier, tableMetadata, context, tableClient, tableConf,
credentials);
+ finalIdentifier,
+ tableMetadata,
+ context,
+ tableClient,
+ tableConf,
+ credentials,
+ readRestrictions);
String eTag = responseHeaders.getOrDefault(HttpHeaders.ETAG, null);
- if (eTag != null) {
+ if (eTag != null && readRestrictions.isEmpty()) {
Review Comment:
> Could we require the ETag to cover the complete LoadTableResponse,
including read-restrictions, etc
we don't do this for vended creds too, i feel i should just remove the
readrestriction too from this, wdyt ? we did have a discussion about it and
things like using VARY header, and ended up decide to keep it as it, given the
current ETAG it allows catalog to send a different ETAG is anything changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
