pvary commented on code in PR #17617:
URL: https://github.com/apache/iceberg/pull/17617#discussion_r3782198689


##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -173,6 +173,7 @@ private static List<Record> project(List<Record> records, 
Schema targetSchema) {
           .flatMap(
               format ->
                   Arrays.stream(DataGenerators.ALL)
+                      .filter(generator -> 
generator.supportedFormats().contains(format))

Review Comment:
   Could we use a FEATURE for Variant?
   I would rather keep these limitations in a single place, so we need to check 
a single place to understand what is missing in a file format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to