Guosmilesmile commented on code in PR #17617:
URL: https://github.com/apache/iceberg/pull/17617#discussion_r3782689009


##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -101,6 +104,26 @@ public String toString() {
     }
   }
 
+  static class Variant implements DataGenerator {
+    private final Schema schema =
+        new Schema(Types.NestedField.required(1, "variant_col", 
Types.VariantType.get()));
+
+    @Override
+    public Schema schema() {
+      return schema;
+    }
+
+    @Override
+    public Set<FileFormat> supportedFormats() {
+      return Set.of(FileFormat.PARQUET);

Review Comment:
   Thanks for your support! I just gave it a try with the test in Avro. It 
passes with Spark but fails with Flink. I’ll fix this in a follow-up PR, so for 
now I’ll only mark Parquet as supported in this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to