alexandre-normand commented on PR #1654: URL: https://github.com/apache/iceberg-go/pull/1654#issuecomment-5295237570
>This is a much better scope — thanks for pivoting. The benchmark harness and the int64 boundary coverage for look good.\n\nOne leftover nit: the last benchmark case is named but its func now uses , so it'''s a duplicate of the previous case with a misleading label. Please either drop it or rename it — fine to fix before merge. oops, sorry about that. I just pushed a commit to delete the duplicate/wrongly named test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
