RussellSpitzer commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3798141089
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -552,10 +588,22 @@ private Set<String> manifestsToRewrite(
}
public static class RewriteContentFileResult extends
RewriteResult<ContentFile<?>> {
+ // Map from source manifest path to the byte length of its rewritten
manifest, used by the
+ // manifest-list rewrite to record an accurate manifest_length.
+ private final Map<String, Long> rewrittenManifestLengths =
Maps.newHashMap();
+
+ public Map<String, Long> rewrittenManifestLengths() {
Review Comment:
nit but this should probably be an unmodifiable map. We are currently
exposing this for read and write. So we have this pattern of
Result.getMap.put
Instead of
Result.addLength(manifestPath, length) Or what not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
