RussellSpitzer commented on PR #16910: URL: https://github.com/apache/iceberg/pull/16910#issuecomment-5320822382
From architectural prospective. I think we should avoid adding new apis, and I think we can do so here by just changing the rewriteManifestList and nothing else. I checked out @varun-lakhyani 's proposal as well, It looks like Varun's pays a little bit in IO for each manifest which is pretty straight forward but straightforward This Pr returns the length along with the result object but changes a some return signatures and adds new methods to do it. Ideally I think we would want to change RewriteResult so that we can keep the methods as they are, the revapi breaks from disrupting the existing APIs are I think warranted because they basically cannot be used correctly as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
