danielcweeks commented on code in PR #17709: URL: https://github.com/apache/iceberg/pull/17709#discussion_r3805853751
########## core/src/main/java/org/apache/iceberg/rest/signing/RemoteSigningConfig.java: ########## @@ -16,15 +16,32 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.iceberg.aws.s3.signer; +package org.apache.iceberg.rest.signing; Review Comment: I don't think we need to create a new package just for two classes. This makes more sense to just put under `org.apache.iceberg.rest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
