adutra commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3806121678
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -85,6 +87,7 @@ class RESTTableScan extends DataTableScan {
private final ParserContext parserContext;
private final Map<String, String> catalogProperties;
private final Object hadoopConf;
+ private final RemoteSigningConfig remoteSigningConfig;
Review Comment:
Yes, I went with the option of serializing the config. That's way easier
then passing down the `RemoteSigningConfig` object through the various `FileIO`
layers until it reaches the signer. Also, that would require creating a
serializable impl of `RemoteSigningConfig` (for Kryo mostly) and also
introducing a new `SupportsRemoteSigning` marker interface to distinguish which
`FileIO` impls support remote signing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
