pvary commented on a change in pull request #2052:
URL: https://github.com/apache/iceberg/pull/2052#discussion_r553874344
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java
##########
@@ -60,18 +60,23 @@ static TestHiveShell shell() {
}
static TestTables testTables(TestHiveShell shell, TestTables.TestTableType
testTableType, TemporaryFolder temp)
- throws IOException {
+ throws IOException {
return testTableType.instance(shell.metastore().hiveConf(), temp);
}
static void init(TestHiveShell shell, TestTables testTables, TemporaryFolder
temp, String engine) {
+ init(shell, testTables, temp, engine, "false");
Review comment:
Could we use a boolean instead of the string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
