pvary commented on a change in pull request #2052:
URL: https://github.com/apache/iceberg/pull/2052#discussion_r553876291
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -142,29 +164,61 @@ public void testScanTable() throws IOException {
// Adding the ORDER BY clause will cause Hive to spawn a local MR job this
time.
List<Object[]> descRows =
- shell.executeStatement("SELECT first_name, customer_id FROM
default.customers ORDER BY customer_id DESC");
+ shell.executeStatement("SELECT first_name, customer_id FROM
default.customers ORDER BY customer_id DESC");
Assert.assertEquals(3, descRows.size());
- Assert.assertArrayEquals(new Object[] {"Trudy", 2L}, descRows.get(0));
- Assert.assertArrayEquals(new Object[] {"Bob", 1L}, descRows.get(1));
- Assert.assertArrayEquals(new Object[] {"Alice", 0L}, descRows.get(2));
+ Assert.assertArrayEquals(new Object[]{"Trudy", 2L}, descRows.get(0));
+ Assert.assertArrayEquals(new Object[]{"Bob", 1L}, descRows.get(1));
+ Assert.assertArrayEquals(new Object[]{"Alice", 0L}, descRows.get(2));
+ }
Review comment:
Am I right that these are formatting only changes?
It is much easier if we do not have them, so I usually try to avoid them in
my PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
