pvary commented on a change in pull request #2053:
URL: https://github.com/apache/iceberg/pull/2053#discussion_r553899268
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergRecordObjectInspector.java
##########
@@ -35,21 +35,30 @@
public final class IcebergRecordObjectInspector extends StructObjectInspector {
private static final IcebergRecordObjectInspector EMPTY =
- new IcebergRecordObjectInspector(Types.StructType.of(),
Collections.emptyList());
+ new IcebergRecordObjectInspector(Types.StructType.of(),
Collections.emptyList(), true);
private final List<IcebergRecordStructField> structFields;
+ private final List<IcebergRecordStructField> structFieldsInLowercase;
Review comment:
Why do we keep both of the fields? Shouldn't we just keep the currently
requested version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
