dixingxing0 commented on a change in pull request #2053:
URL: https://github.com/apache/iceberg/pull/2053#discussion_r553901117
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -82,10 +82,17 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
}
String[] selectedColumns =
ColumnProjectionUtils.getReadColumnNames(configuration);
- Schema projectedSchema = selectedColumns.length > 0 ?
tableSchema.select(selectedColumns) : tableSchema;
+ Schema projectedSchema = tableSchema;
+
+ boolean caseSensitive =
configuration.getBoolean(InputFormatConfig.CASE_SENSITIVE,
Review comment:
Agree with you, i'll make here go with `false`, i don't have a specific
use-case.
Since we make hive go with `false`, i think iceberg.mr.case.sensitive should
use `true` as a default value, is that ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
