moomindani commented on PR #17177: URL: https://github.com/apache/iceberg/pull/17177#issuecomment-5376963879
@danielcweeks would you be willing to take a look? This is the S3FileIO side of #14439 (S3-compatible stores rejecting the SDK's CRC32 trailer headers), reviving #15391 by @rcjverhoef with his commit preserved. It has been open six weeks without a review; I rebased it onto current `main` and CI is green. The part I would most like a maintainer's read on is the default. This PR deliberately leaves the AWS SDK defaults in place when the properties are unset, so there is no behavior change and `s3.request-checksum-calculation=when_required` is strictly opt-in. The alternative — defaulting to `when_required` so S3FileIO works out of the box against Dell ECS, GCS's S3-compatible API and similar stores — is a behavior change I did not want to make unilaterally. If you think that is the better default, I am happy to change it here or take it to dev@. #17179 stacks on this one and adds `s3.checksum-algorithm`; no need to look at that one until this shape is settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
