tanmayrauth opened a new pull request, #1861: URL: https://github.com/apache/iceberg-go/pull/1861
Partition decoding asserted v.(int64) unchecked on every time and timestamp arm. A manifest that declares a time/timestamp logicalType on an underlying Avro type the spec forbids (e.g. timestamp-millis on an int) decodes to a raw int32, panicking Partition() with no way to recover. time-millis and timestamp-millis were also returned as milliseconds though iceberg.Time and iceberg.Timestamp count microseconds, 1000x too small. Accept the raw int32/int64 value and scale milliseconds to microseconds. Closes #1487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
