danielcweeks commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r3844697054
########## format/spec.md: ########## @@ -1913,6 +1916,14 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Row-level delete changes: + +* Equality delete files must not be added to v4 tables +* Readers must continue to apply equality deletes for v2 and v3 tables and for equality deletes carried over into upgraded v4 tables +* Upgrading a v2 or v3 table to v4 is metadata-only and does not rewrite data or delete files + * Equality deletes remain in the carried-over v2 or v3 delete manifests that already track them + * Converting equality deletes to DVs is a separate, optional maintenance action Review Comment: I don't think we need these two sub-bullets. The first restates the main bullet and I don't think we want to reference the maintenance actions from the sepc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
