danielcweeks commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r3844741181
########## format/spec.md: ########## @@ -1352,13 +1353,13 @@ Notes: ### Delete Formats -This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. +This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. Equality delete files must not be added to v4 tables, but existing equality delete files are valid. There are different formats for encoding row-level deletes: * Deletion vectors (DVs) identify deleted rows within a single referenced data file by position in a bitmap * Position delete files identify deleted rows by file location and row position (**deprecated** in v3) -* Equality delete files identify deleted rows by the value of one or more columns +* Equality delete files identify deleted rows by the value of one or more columns (**deprecated** in v4) Review Comment: ```suggestion * Equality delete files identify deleted rows by the value of one or more columns (**prohibited** in v4) ``` A bit of a nit (and fully aware it's used directly above in relation to row-level deletes): __deprecated__ means "discouraged" and in this context we're actually prohibiting use. This is a common misuse, but I rather be explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
