RussellSpitzer commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3844885306


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -599,7 +614,8 @@ private RewriteContentFileResult rewriteManifests(
                 sourcePrefix,
                 targetPrefix,
                 rewrittenDeleteFileSizes),
-            Encoders.bean(RewriteContentFileResult.class))
+            // Encoders.bean derives an empty schema here and would drop the 
copy plan and lengths

Review Comment:
   This feels unrelated to this change, and currently has no tests that break 
with it unchanged. I would change it back and have a follow up if we want to 
make a defensive change here. But as is I don't think this is actually broken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to