RussellSpitzer commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3844801719
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -363,6 +363,96 @@ public void testFullTableRewritePath() throws Exception {
checkFileNum(3, 2, 2, 9, result);
}
+ @TestTemplate
+ public void testManifestLengthAfterRewrite() throws Exception {
Review Comment:
We don't really nee individual tests for this. Every test we do that
rewrites manifests should also check to see that the lengths are the same. You
already have this in a helper assertManifestLengthsMatchOnDisk which we should
just be calling on all of the tests (except Incremental rewrites). Then we can
remove tests that are just checking this invariant which we expect to be true
all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
