hedger9487 opened a new pull request, #3846: URL: https://github.com/apache/iceberg-python/pull/3846
### Description Fixes #3337. In `SqlCatalog`, `_iceberg_type_filter()` was added in #3263 to filter on `iceberg_type` (matching `TABLE` or `NULL`) and avoid operating on `VIEW` rows written by other Iceberg implementations (e.g., Java or Rust). While `load_table`, `drop_table`, `rename_table`, and `list_tables` incorporate this filter, `commit_table` omitted `type_filter` in its SQL update statement. This PR applies `type_filter = self._iceberg_type_filter()` to the `commit_table` update query in `pyiceberg/catalog/sql.py`. ### Testing - Added unit test `test_commit_table_ignores_view_rows` in `tests/catalog/test_sql.py`. - All 31 catalog unit tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
