ebyhr commented on code in PR #3846:
URL: https://github.com/apache/iceberg-python/pull/3846#discussion_r3859036769
##########
tests/catalog/test_sql.py:
##########
@@ -388,6 +389,31 @@ def test_rename_table_ignores_view_rows(warehouse: Path)
-> None:
assert row[0] == "VIEW"
+def test_commit_table_ignores_view_rows(warehouse: Path) -> None:
Review Comment:
I don't think this is a valid regression test. It passes even if I revert
`sql.py`'s change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
