JosephLenton opened a new pull request, #3065:
URL: https://github.com/apache/iceberg-rust/pull/3065
## Which issue does this PR close?
This is a part of the upgrade to Avro 0.22. We currently serialise the
manifest `first_row_id` as a `u64`, and this is incorrect and out of spec.
From the Iceberg spec:
* `first_row_id` is defined as a `long` - see:
https://iceberg.apache.org/spec/#manifest-lists
* a long is defined as a `64-bit signed integer` - see:
https://iceberg.apache.org/spec/#primitive-types
This is relevant to the Avro 0.22 upgrade because:
- in version 0.21, serialising a `u64` as a long is allowed. It is silently
coerced.
- in version 0.22, this fails and is rejected.
- Closes some of #3063
I am making this change on it's own to help isolate changes (and to isolate
discussion in case I am wrong).
## What changes are included in this PR?
- Change from serialising `first_row_id` as a `u64` to an `i64`.
## Are these changes tested?
- Ran tests. They passed.
## AI Disclosure
The code changes and this PR comment is all made by a human.
Claude was used to debug the issue, and as a search. This included in code,
and in spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
