dannycjones commented on PR #3065: URL: https://github.com/apache/iceberg-rust/pull/3065#issuecomment-5423192496
@blackmwk and/or @CTTY, would you be able to check this is the right direction? I don't want to lead us on a larger change. I see that there's a few types even for V2 (`ManifestFile::existing_rows_count`) that are unsigned in Rust, but in the spec are presumably signed assuming that its referring to Java types. I am proposing to move from `u64` to `i64`, which loses the guarantee in the library that these are positive (which they always should be) however the signed equivalent more closely represents what's described in the spec and serialized to Avro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
