singhpk234 commented on code in PR #17817:
URL: https://github.com/apache/iceberg/pull/17817#discussion_r3858531115
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -461,7 +463,13 @@ private void refreshStorageCredentials() {
return;
}
- try (VendedCredentialsProvider provider =
VendedCredentialsProvider.create(properties)) {
+ Map<String, String> refreshProperties = Maps.newHashMap(properties);
+ String endpoint =
+ RESTUtil.resolveEndpoint(
+ properties.get(CatalogProperties.URI),
properties.get(VendedCredentialsProvider.URI));
+ refreshProperties.put(VendedCredentialsProvider.URI, endpoint);
Review Comment:
can we add a test for this ? also i wonder which catalog is it which returns
relative path here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
