shoemoney commented on PR #17817: URL: https://github.com/apache/iceberg/pull/17817#issuecomment-5444977096
Added a test (credentialRefreshResolvesRelativeCredentialsUri, 649dbdf) that covers a relative credentials.uri. On which catalog returns it relative: it's not catalog-specific. client.refresh-credentials-endpoint / credentials.uri isn't required to be absolute anywhere in the REST spec, it's just a table config value the catalog server sets. AwsClientProperties already resolves it against catalog.uri when the provider is first built, but S3FileIO's own refresh path was reading the raw property straight off the table config, so any server that hands back a relative value there would hit this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
