Revanth14 commented on code in PR #1871:
URL: https://github.com/apache/iceberg-go/pull/1871#discussion_r3860265667
##########
table/snapshots.go:
##########
@@ -272,9 +272,27 @@ type Snapshot struct {
func (s *Snapshot) UnmarshalJSON(data []byte) error {
type Alias Snapshot
var next Alias
- if err := json.Unmarshal(data, &next); err != nil {
+ // snapshot-id and timestamp-ms are required by the spec for every
format
+ // version. Decode them through pointers so an absent or null field
stays
+ // distinguishable from an explicit zero, which would otherwise be
accepted
+ // as a valid identity or as the Unix epoch.
+ aux := struct {
+ SnapshotID *int64 `json:"snapshot-id"`
+ TimestampMs *int64 `json:"timestamp-ms"`
Review Comment:
Thanks for pointing these out. `SnapshotLogEntry` and `MetadataLogEntry`
appear to need similar required-field validation, but I’d prefer to address
them separately to keep this PR focused on #1869.
The manifest requirement is also version-dependent: v1 may use the legacy
`manifests` field, while `manifest-list` is required in v2 and v3. Since
`Snapshot.UnmarshalJSON` does not know the table format version, this
validation would be better handled at the metadata level in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
