Revanth14 commented on code in PR #1871:
URL: https://github.com/apache/iceberg-go/pull/1871#discussion_r3860334519
##########
table/snapshots.go:
##########
@@ -272,9 +272,27 @@ type Snapshot struct {
func (s *Snapshot) UnmarshalJSON(data []byte) error {
type Alias Snapshot
var next Alias
- if err := json.Unmarshal(data, &next); err != nil {
+ // snapshot-id and timestamp-ms are required by the spec for every
format
+ // version. Decode them through pointers so an absent or null field
stays
+ // distinguishable from an explicit zero, which would otherwise be
accepted
+ // as a valid identity or as the Unix epoch.
+ aux := struct {
+ SnapshotID *int64 `json:"snapshot-id"`
+ TimestampMs *int64 `json:"timestamp-ms"`
+ *Alias
+ }{Alias: &next}
Review Comment:
Thanks, that makes sense. I’ll decode into the alias first and only inspect
the raw fields when either `snapshot-id` or `timestamp-ms` has its zero value.
The fallback will check both field presence and JSON `null`, so missing or
null values remain invalid while explicit numeric zero remains accepted. This
keeps the normal nonzero path on the existing direct decode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
