dramaticlly commented on code in PR #16028:
URL: https://github.com/apache/iceberg/pull/16028#discussion_r3875993404
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/BaseSparkTable.java:
##########
@@ -91,11 +94,29 @@ public String name() {
return table.toString();
}
+ /**
+ * @deprecated since 1.12.0, use {@link #columns()} instead
Review Comment:
Usually for code deprecation we will also include the version to remove.
However I believe for multi-version engine support we tend to bundle as we
prepare to add new spark version support. I think we can still have a blanket
removal such as 2.0.0 to ensure this is eventually actionable.
Also, I think there's many callers make use of deprecated method here, like
https://github.com/apache/iceberg/blob/3149892438ec7d4114fc2d79e970188dd3c90a44/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java#L46
and
https://github.com/apache/iceberg/blob/3149892438ec7d4114fc2d79e970188dd3c90a44/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestPathIdentifier.java#L73-L74.
Do we intend to follow up after this is is merged?
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseTableCreationSparkAction.java:
##########
@@ -156,10 +155,11 @@ protected StagingTableCatalog
checkDestinationCatalog(CatalogPlugin catalog) {
protected StagedSparkTable stageDestTable() {
try {
Map<String, String> props = destTableProps();
- StructType schema = sourceTable.schema();
- Transform[] partitioning = sourceTable.partitioning();
return (StagedSparkTable)
- destCatalog().stageCreate(destTableIdent(), schema, partitioning,
props);
+ destCatalog()
+ .stageCreate(
+ destTableIdent(),
+ Spark3Util.tableInfo(sourceTable.columns(),
sourceTable.partitioning(), props));
Review Comment:
for moving from sourceTable.schema() to sourceTable.columns(), Is this a
concern for table migrate/snapshot for hive source table (V1Table) with column
DEFAULTs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
