manuzhang commented on code in PR #16028:
URL: https://github.com/apache/iceberg/pull/16028#discussion_r3886931130
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseTableCreationSparkAction.java:
##########
@@ -156,10 +155,11 @@ protected StagingTableCatalog
checkDestinationCatalog(CatalogPlugin catalog) {
protected StagedSparkTable stageDestTable() {
try {
Map<String, String> props = destTableProps();
- StructType schema = sourceTable.schema();
- Transform[] partitioning = sourceTable.partitioning();
return (StagedSparkTable)
- destCatalog().stageCreate(destTableIdent(), schema, partitioning,
props);
+ destCatalog()
+ .stageCreate(
+ destTableIdent(),
+ Spark3Util.tableInfo(sourceTable.columns(),
sourceTable.partitioning(), props));
Review Comment:
Both before and after this PR, Hive column defaults are not transferred into
the Iceberg schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
