blackmwk commented on code in PR #3101:
URL: https://github.com/apache/iceberg-rust/pull/3101#discussion_r3880449595
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
+ #[property(key = MEMORY_CATALOG_WAREHOUSE, default = "")]
+ warehouse: String,
+ #[property(prefix = "")]
+ props: HashMap<String, String>,
Review Comment:
Remove this.
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
Review Comment:
```suggestion
pub struct MemoryCatalogProperties {
```
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
+ #[property(key = MEMORY_CATALOG_WAREHOUSE, default = "")]
+ warehouse: String,
+ #[property(prefix = "")]
+ props: HashMap<String, String>,
+}
+
#[derive(Clone, Debug)]
pub(crate) struct MemoryCatalogConfig {
Review Comment:
We no longer need this, we should maintain name and
`MemoryCatalogProperties` in MemoryCatalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
