blackmwk commented on code in PR #3101:
URL: https://github.com/apache/iceberg-rust/pull/3101#discussion_r3888133164
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -156,9 +152,13 @@ impl MemoryCatalog {
let factory = storage_factory.unwrap_or_else(||
Arc::new(MemoryStorageFactory));
Ok(Self {
+ name,
+ properties,
+ file_io: FileIOBuilder::new(factory)
+ .with_props(props.clone())
Review Comment:
Removed the raw `props` field from `MemoryCatalog` and now move the map
directly into `FileIOBuilder`, eliminating the clone in 994b5956.
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -458,6 +468,31 @@ pub(crate) mod tests {
temp_dir.path().to_str().unwrap().to_string()
}
+ #[test]
+ fn test_catalog_properties() {
Review Comment:
Added the dedicated `test_catalog_properties_with_default_warehouse` unit
test, which verifies that an omitted warehouse uses the empty default, in
994b5956.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
