xanderbailey commented on code in PR #3108:
URL: https://github.com/apache/iceberg-rust/pull/3108#discussion_r3882338438
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -347,10 +344,10 @@ impl<'a> TableScanBuilder<'a> {
/// Table scan.
#[derive(Debug)]
pub struct TableScan {
- /// A [PlanContext], if this table has at least one snapshot, otherwise
None.
- ///
- /// If this is None, then the scan contains no rows.
- plan_context: Option<PlanContext>,
+ /// The snapshot being scanned, if this table has at least one snapshot.
+ /// When absent the scan yields no rows.
+ snapshot: Option<SnapshotRef>,
Review Comment:
needed because TableScan has a pub api to ask for it's snapshot and I didn't
want to break that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
