xanderbailey commented on code in PR #3108:
URL: https://github.com/apache/iceberg-rust/pull/3108#discussion_r3882160697
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -177,44 +178,16 @@ pub(crate) struct PlanContext {
}
impl PlanContext {
- pub(crate) async fn get_manifest_list(&self) -> Result<Arc<ManifestList>> {
- self.object_cache
- .as_ref()
- .get_manifest_list(&self.snapshot, &self.table_metadata)
- .await
- }
-
- /// Returns the partition filter for a manifest. See
[`PartitionFilterCache::get`] for the
- /// always-true fallback when the manifest's spec cannot be resolved
against the scan schema.
- fn get_partition_filter(&self, manifest_file: &ManifestFile) ->
Result<Arc<BoundPredicate>> {
Review Comment:
moved private method down to make pub (crate) more obvious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
