dramaticlly commented on code in PR #17853:
URL: https://github.com/apache/iceberg/pull/17853#discussion_r3882344436
##########
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##########
@@ -618,6 +618,10 @@ public ReadBuilder createResolvingReader(
return this;
}
+ /**
+ * @deprecated will be removed in 1.13.0; use {@link
#createResolvingReader(Function)} instead.
Review Comment:
thanks @kinolaev for the change, but I think it's better to follow the
convention in https://iceberg.apache.org/contribute/#deprecation-notices
to state both deprecated since, target removal version and if there's any
replacement to use. There's some inconsistence across 3 deprecation notice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
