dramaticlly commented on code in PR #17853:
URL: https://github.com/apache/iceberg/pull/17853#discussion_r3882861148
##########
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##########
@@ -618,6 +618,11 @@ public ReadBuilder createResolvingReader(
return this;
}
+ /**
+ * @deprecated since 1.12.0, will be removed in 1.13.0; use {@link
+ * #createResolvingReader(Function)} instead.
Review Comment:
This reads like a drop-in replacement but I think new function takes
different parameters, as iceberg schema instead of Avro schema, and it rely on
caller to call `setSchema(avroSchema)` first.
##########
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##########
Review Comment:
this also looks not used, especially after ProjectionDatumReader removal,
might worth considering as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
