yyanyy commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r555463456
##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -199,6 +200,16 @@ default boolean hasDeletedFiles() {
*/
boolean containsNull();
+ /**
+ * Returns true if at least one data file in the manifest has a nan value
for the field.
+ * Null if this information doesn't exist.
+ * <p>
+ * Default to return null to ensure backward compatibility.
+ */
+ default Boolean containsNaN() {
+ return null;
Review comment:
I think `PartitionSummary` is populated when trying to write a file, so
if the code contains this change, it will populate and write NaN boolean
correctly. I guess you might be thinking about `GenericPartitionFieldSummary`
when you mention returning true as default since that's the class to be
constructed when reading from avro files that may not contain this info?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
