marton-bod commented on a change in pull request #2052:
URL: https://github.com/apache/iceberg/pull/2052#discussion_r555704455
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -68,17 +83,20 @@
Types.TimestampType.withoutZone(), Types.StringType.get(),
Types.BinaryType.get(),
Types.DecimalType.of(3, 1));
- @Parameters(name = "fileFormat={0}, engine={1}, catalog={2}")
+ @Parameters(name = "fileFormat={0}, engine={1}, catalog={2}, cboEnable={3}")
public static Collection<Object[]> parameters() {
Collection<Object[]> testParams = new ArrayList<>();
String javaVersion = System.getProperty("java.specification.version");
+ List<Boolean> cboEnables = ImmutableList.of(true, false);
Review comment:
Instead of running all tests for both CBO on/off, can we turn it on just
in those one or two unit test cases where we want to test it, by setting it via
`shell.setHiveSessionValue()` at the beginning of the test? We're trying to
prevent the number of test runs from exploding via the combination of
ever-increasing test parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
