fmorillo7694 commented on PR #17631: URL: https://github.com/apache/iceberg/pull/17631#issuecomment-5476353031
@waterWang thanks for this fix — we hit the same issue and your visitor overrides are exactly right (confirmed with a local reproduction against 1.11.0, details in #17615). Two things this branch needs to be mergeable against current `main`: - It targets `flink/v2.0`, which has since been removed (`main` now has `v1.20`, `v2.1`, `v2.2`, `v2.3`) — so it needs a rebase and retarget to `v2.1`/`v2.2`/`v2.3`. - The `v1.20` `DataConverter` change can't compile there: Flink 1.20 has no `LogicalTypeRoot.VARIANT`, so `v1.20` is best left out entirely (the code path is unreachable on Flink 1.20 anyway). Since 1.12 hasn't been cut yet, it would be great to land this in time. To keep it moving I opened #17900 with your fix retargeted to the current modules plus test coverage for the visitors and `DataConverter` — with you credited as co-author on the commit. Happy to go either way: if you'd prefer to update this PR, I'll close #17900 in its favor — or if it's easier, add me as a collaborator on your fork and I can push the retarget and tests directly here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
