gorewilliams opened a new issue, #3882:
URL: https://github.com/apache/iceberg-python/issues/3882

   ### Feature Request / Improvement
   
   Ruff is currently configured in a standalone `ruff.toml` at the repo root, 
while every other tool config lives in `pyproject.toml` 
(`[tool.pytest.ini_options]`, `[tool.mypy]`, `[tool.coverage.run]`, 
`[tool.uv]`). Ruff is the only exception.
   
   **Why it's split today**
   
   The split was introduced in #619 (April 2024). Per the commit message: 
Dependabot broke after #442 and started erroring on the project's 
`pyproject.toml`, and moving the Ruff config out was the workaround.
   
   **Why it may no longer be needed**
   
   That workaround dates from when the project was on Poetry. `pyproject.toml` 
on `main` is now PEP 621 metadata with a setuptools backend plus `[tool.uv]`, 
so the Dependabot parsing path that motivated #619 is not the one in use 
anymore.
   
   **What the change would involve**
   
   - Move the contents of `ruff.toml` into `pyproject.toml` under 
`[tool.ruff]`, `[tool.ruff.lint]`, `[tool.ruff.lint.isort]`, 
`[tool.ruff.lint.pyupgrade]`, and `[tool.ruff.format]`
   - Delete `ruff.toml`
   
   (Nothing appears to reference the file by path: the `ruff` and `ruff-format` 
hooks in `.pre-commit-config.yaml` pass no `--config`, `nbqa-ruff` passes no 
`--config`, etc. Ruff's own discovery would pick up `[tool.ruff]` from 
`pyproject.toml` once `ruff.toml` is removed.)
   
   Happy to open the PR if there's agreement on the direction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to