blackmwk commented on code in PR #3107: URL: https://github.com/apache/iceberg-rust/pull/3107#discussion_r3901475299
########## crates/iceberg/src/test_utils/mod.rs: ########## @@ -19,6 +19,9 @@ //! This module is pub just for internal testing. //! It is subject to change and is not intended to be used by external users. +#[cfg(test)] +pub(crate) mod scan; Review Comment: No, we should mark the whole test_utils mod available only in test configuration.. I know it will break pub api, but it's necessary, these are not api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
