xanderbailey commented on code in PR #3107:
URL: https://github.com/apache/iceberg-rust/pull/3107#discussion_r3902685126
##########
crates/iceberg/src/test_utils/mod.rs:
##########
@@ -19,6 +19,9 @@
//! This module is pub just for internal testing.
//! It is subject to change and is not intended to be used by external users.
+#[cfg(test)]
+pub(crate) mod scan;
Review Comment:
The issue is then we can't use these across crate boundaries:
```
error[E0432]: unresolved import `iceberg::test_utils`
--> crates/catalog/rest/src/catalog.rs:1668:18
-->
crates/integrations/datafusion/tests/integration_datafusion_test.rs:34:14
-->
crates/integrations/datafusion/src/physical_plan/project.rs:193:18
-->
crates/integrations/datafusion/src/physical_plan/repartition.rs:185:18
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
