plusplusjiajia commented on code in PR #2651:
URL: https://github.com/apache/iceberg-rust/pull/2651#discussion_r3911580913
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1465,8 +1484,10 @@ impl SessionCatalog for RestSessionCatalog {
}
};
+ // The commit response carries no credentials, so build a plain FileIO;
+ // the transaction layer reuses the credentialed one it already holds.
let file_io = self
- .load_file_io(Some(&response.metadata_location), None)
+ .load_file_io(Some(&response.metadata_location), None, None)
Review Comment:
@xanderbailey Good question. No risk on the `Transaction::commit` path:
`do_commit` loads before committing and swaps that load's credentialed FileIO
back in afterwards (`with_file_io`), reloading on `SetLocation`. Refresh isn't
needed here. Only a direct `Catalog::update_table` caller sees the plain
FileIO, and the commit response has no credentials to give it by spec — I've
pointed the comment at `do_commit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
