anoopj commented on code in PR #17932:
URL: https://github.com/apache/iceberg/pull/17932#discussion_r3919050338
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -410,6 +414,122 @@ public DeleteFile copyWithStats(Set<Integer>
requestedColumnIds) {
}
}
+ /** Adapts a TrackedFile to {@link ManifestFile}. */
+ private static class TrackedManifestFile implements ManifestFile {
+ private final TrackedFile file;
+
+ private TrackedManifestFile(TrackedFile file) {
+ Tracking tracking = file.tracking();
+ Preconditions.checkArgument(
+ tracking.dataSequenceNumber() != null, "Invalid data sequence
number: null");
+ Preconditions.checkArgument(
Review Comment:
Note to reviewers: It is unclear whether we need to do these validations
during read time here. Also, we don't validate snapshot IDs currently. I'm OK
to just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
