anoopj commented on code in PR #17932:
URL: https://github.com/apache/iceberg/pull/17932#discussion_r3919054538


##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -410,6 +414,122 @@ public DeleteFile copyWithStats(Set<Integer> 
requestedColumnIds) {
     }
   }
 
+  /** Adapts a TrackedFile to {@link ManifestFile}. */
+  private static class TrackedManifestFile implements ManifestFile {
+    private final TrackedFile file;
+
+    private TrackedManifestFile(TrackedFile file) {
+      Tracking tracking = file.tracking();
+      Preconditions.checkArgument(
+          tracking.dataSequenceNumber() != null, "Invalid data sequence 
number: null");
+      Preconditions.checkArgument(
+          tracking.dataSequenceNumber().equals(tracking.fileSequenceNumber()),
+          "Manifest data and file sequence numbers must be equal, got %s and 
%s",
+          tracking.dataSequenceNumber(),
+          tracking.fileSequenceNumber());
+      this.file = file;
+    }
+
+    @Override
+    public String path() {
+      return file.location();
+    }
+
+    @Override
+    public long length() {
+      return file.fileSizeInBytes();
+    }
+
+    @Override
+    public int partitionSpecId() {
+      throw new UnsupportedOperationException(
+          "v4 manifests are not bound to a single partition spec");
+    }
+
+    @Override
+    public ManifestContent content() {
+      switch (file.contentType()) {
+        case DATA_MANIFEST:
+          return ManifestContent.DATA;
+        case DELETE_MANIFEST:
+          return ManifestContent.DELETES;
+        default:
+          throw new IllegalStateException(

Review Comment:
   This is unreachable because we do the validation in the factory method. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to