vbhanuchander-lang commented on PR #17644: URL: https://github.com/apache/iceberg/pull/17644#issuecomment-5518530784
Rebased onto `main` (`8ea7d00`). This had gone stale in a way that needed more than a merge: the Flink version matrix moved under it. `flink/v2.0` was dropped and `flink/v2.3` added, so git's rename detection tried to fold the v2.0 test into v2.2 and conflicted. The change now covers the four versions that exist on `main` — **v1.20, v2.1, v2.2 and v2.3** — instead of the v1.20/v2.0/v2.1 it was originally written against. The v2.3 sources were byte-identical to v2.2 before the change, so it is the same edit in each, as with the other three. `TestFlinkMultisetWrite` passes on all four (4 tests each), and spotless and checkstyle are clean. No change to the fix itself: `FlinkTypeToType#visit(MultisetType)` already converts a Flink `MULTISET<T>` to an Iceberg `map<T, int>`, and `RowData` represents both as `MapData`, so the three visitors just need to treat a `MultisetType` as its equivalent `MapType` rather than failing the cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
