vbhanuchander-lang commented on PR #17613: URL: https://github.com/apache/iceberg/pull/17613#issuecomment-5518540643
Re-checked against `main` (`8ea7d00`): still `MERGEABLE`, checks green, no conflicts. Restating the scope, because "support timestamp_ns" sounds larger than this is: the generic object model already handles the type (`GenericDataUtil` has the `TIMESTAMP_NANO` case), and every other temporal type is already handled in `RecordConverter`. `timestamp_ns` is the one that falls through to `UnsupportedOperationException`, so writing that column through the Kafka Connect sink fails outright while Spark writes it fine. The change is the missing `case`, plus tests. It is part of #15443 but does not depend on the rest of it. @bryanck @mxm you have both been through `kafka-connect` recently — is this the right shape, or would you rather `timestamp_ns` wait for the wider v3-types work in #15443? Either answer is useful; it has been open since 12 Aug with no signal in either direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
